BS-PR-709 - Guarded editor shutdown and clean history savepoints #55
Closed
opened 2026-07-13 01:00:16 -04:00 by Rbanh
·
1 comment
No Branch/Tag Specified
main
codex/m2-content-workspace
codex/fbx-external-textures
codex/deterministic-asset-fingerprints
codex/guarded-shutdown-savepoints
codex/sample-regression-pack
codex/operator-invariants-completion
codex/renderer-foundation-acceptance
codex/collider-diagnostics
codex/physics-placement
codex/terrain-material-layers
codex/terrain-sculpt-strokes
codex/terrain-foundation
codex/non-blocking-native-dialogs
codex/collaboration-live-acceptance
codex/material-library-targeted-drop
codex/source-control-collaboration-safety
codex/renderer-material-component-foundation
No results found.
Labels
Clear labels
area:animation
area:assets
area:audio
area:brushes
area:build-release
area:extensions
area:governance
area:hierarchy
area:inspector
area:navigation
area:operators
area:physics
area:project-ux
area:quality
area:rendering
area:runtime
area:scene-io
area:terrain
area:viewport
priority:P0
priority:P1
priority:P2
priority:P3
roadmap:jackdaw
roadmap:production
type:architecture
type:docs
type:epic
type:feature
Skeletal animation import, preview, graph/state authoring, and runtime integration.
Asset browser, material browser, thumbnails, import, processing, and asset watcher.
Audio source/listener authoring, buses, spatial preview, and runtime integration.
Brush geometry, CSG, face editing, UVs, and brush diagnostics.
Build profiles, packaging, content validation, release gates, and distribution diagnostics.
Static extension API, extension scaffolds, dylib exploration.
Policy, attribution, planning, and production process.
Outliner hierarchy, parenting, grouping, prefab structure, ordering, and selection workflows.
Inspector, component metadata, component editing UX.
Navigation mesh authoring, baking, diagnostics, and AI path preview.
Editor operator/action framework, undo, commit/cancel semantics.
Physics placement, colliders, rigid bodies, diagnostics, and overlays.
Project launcher, profiles, templates, or first-run project workflow.
Regression packs, tests, performance budgets, profiler, first-hour UX.
Static and skinned renderers, material slots, shaders, ray tracing, and render-path integration.
BRP, remote inspector, PIE, game preview, runtime integration.
Scene document, save/load, schema, migration, or reference repair.
Terrain authoring, terrain sculpting, heightmaps, and terrain materials.
Viewport interaction, selection, shortcuts, camera, overlays, and controls.
Must-have prerequisite or milestone-critical item.
Important production feature after P0 work is stable.
Useful follow-up or polish item.
Exploratory or later spike.
Jackdaw-inspired Blacksite editor roadmap item.
Blacksite production-readiness roadmap item beyond the Jackdaw-inspired foundation.
Architecture, internal framework, or hard-to-reverse technical decision.
Documentation, policy, samples, or issue-board structure.
Tracking epic that groups related milestone work.
User-visible feature or capability.
Milestone
No items
No Milestone
M7 - Content production and shipping
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Falling-Metal-Interactive/Blacksite#55
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Prevent silent loss of authored scene work when closing the editor, and make the dirty marker follow the actual saved history position.
Why
Native operator QA on 2026-07-13 exposed two production blockers:
apply_command_undounconditionally marks the scene dirty and history has no saved-state checkpoint.Alt+F4closed the dirty editor immediately. Dirty confirmation currently protects scene-tab close and project switch, but not native window/application exit. Recovery snapshots reduce impact but are not a substitute for an explicit Save / Discard / Cancel decision.Implementation notes
NativeDialogBroker; never block the render loop.Acceptance criteria
Alt+F4, window close, menu quit, and programmatic editor exit share the guarded path.Docs/tests
Update scene persistence/recovery docs and ADR 0023 if the shutdown contract changes. Packaged-runtime tests remain deferred until re-enabled.
Completed and published on
main.Implementation
4b33f3235761fd0dd3daf219e5bbbaee884eb626a048233fceab86649f8c1004137a59f0cd62ac129e23ae731f95dc351ecc744d6ca61f6bc4467317(#57)Source gates at the #55 implementation
cargo fmt --all -- --check: passgit diff --check: passcargo clippy --workspace --all-targets -- -D warnings: passcargo test --workspace --all-targets --no-fail-fast: pass; editor 282 testsNative Linux acceptance
The temporary QA scene was removed. Packaged-runtime acceptance remains explicitly owner-deferred; no packaged result or production-candidate signoff is claimed.