BS-PR-710 - Keep editor actions safe during scoped UI rendering #57
Closed
opened 2026-07-13 05:59:06 -04:00 by Rbanh
·
1 comment
codex/guarded-shutdown-savepoints
Clear current reference
main
codex/m2-content-workspace
codex/fbx-external-textures
codex/deterministic-asset-fingerprints
codex/guarded-shutdown-savepoints
codex/sample-regression-pack
codex/operator-invariants-completion
codex/renderer-foundation-acceptance
codex/collider-diagnostics
codex/physics-placement
codex/terrain-material-layers
codex/terrain-sculpt-strokes
codex/terrain-foundation
codex/non-blocking-native-dialogs
codex/collaboration-live-acceptance
codex/material-library-targeted-drop
codex/source-control-collaboration-safety
codex/renderer-material-component-foundation
Clear current reference
No results found.
Labels
Clear labels
area:animation
area:assets
area:audio
area:brushes
area:build-release
area:extensions
area:governance
area:hierarchy
area:inspector
area:navigation
area:operators
area:physics
area:project-ux
area:quality
area:rendering
area:runtime
area:scene-io
area:terrain
area:viewport
priority:P0
priority:P1
priority:P2
priority:P3
roadmap:jackdaw
roadmap:production
type:architecture
type:docs
type:epic
type:feature
Skeletal animation import, preview, graph/state authoring, and runtime integration.
Asset browser, material browser, thumbnails, import, processing, and asset watcher.
Audio source/listener authoring, buses, spatial preview, and runtime integration.
Brush geometry, CSG, face editing, UVs, and brush diagnostics.
Build profiles, packaging, content validation, release gates, and distribution diagnostics.
Static extension API, extension scaffolds, dylib exploration.
Policy, attribution, planning, and production process.
Outliner hierarchy, parenting, grouping, prefab structure, ordering, and selection workflows.
Inspector, component metadata, component editing UX.
Navigation mesh authoring, baking, diagnostics, and AI path preview.
Editor operator/action framework, undo, commit/cancel semantics.
Physics placement, colliders, rigid bodies, diagnostics, and overlays.
Project launcher, profiles, templates, or first-run project workflow.
Regression packs, tests, performance budgets, profiler, first-hour UX.
Static and skinned renderers, material slots, shaders, ray tracing, and render-path integration.
BRP, remote inspector, PIE, game preview, runtime integration.
Scene document, save/load, schema, migration, or reference repair.
Terrain authoring, terrain sculpting, heightmaps, and terrain materials.
Viewport interaction, selection, shortcuts, camera, overlays, and controls.
Must-have prerequisite or milestone-critical item.
Important production feature after P0 work is stable.
Useful follow-up or polish item.
Exploratory or later spike.
Jackdaw-inspired Blacksite editor roadmap item.
Blacksite production-readiness roadmap item beyond the Jackdaw-inspired foundation.
Architecture, internal framework, or hard-to-reverse technical decision.
Documentation, policy, samples, or issue-board structure.
Tracking epic that groups related milestone work.
User-visible feature or capability.
Milestone
No items
No Milestone
M7 - Content production and shipping
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Falling-Metal-Interactive/Blacksite#57
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Keep synchronous editor UI actions safe while the main egui state is temporarily scoped out of the ECS world during rendering.
Why
Native #55 acceptance on 2026-07-13 reproduced an immediate editor crash after File > New Scene followed by toolbar Spawn cube:
show_ui_systemintentionally ownsUiStatethrough Bevyresource_scopewhile drawing the editor. Synchronous UI callbacks must use state already owned by that UI call or communicate through independent resources; they cannot query the temporarily absentUiState.Independent review found the same root in:
UiStatelookup always fails inside the scope.Deferred command-palette actions run after the scope and are not affected.
Implementation notes
SelectedEntity; let end-of-pass reconciliation update the owned egui selection.resource_scopearchitecture unchanged.UiStatelookup.Acceptance criteria
UiStatescoped out.Docs/tests
This restores intended workflows rather than changing them. Record the native regression evidence and exact commit. Packaged-runtime tests remain owner-deferred.
BS-PR-710 - Keep toolbar authoring safe during scoped UI renderingto BS-PR-710 - Keep editor actions safe during scoped UI renderingCompleted and published on
main.Implementation
9e23ae731f95dc351ecc744d6ca61f6bc4467317a048233fceab86649f8c1004137a59f0cd62ac12Source gates
cargo fmt --all -- --check: passgit diff --check: passcargo clippy --workspace --all-targets -- -D warnings: passcargo test --workspace --all-targets --no-fail-fast: pass; editor 290/290Native Linux acceptance
Packaged-runtime acceptance remains explicitly owner-deferred; no production-candidate signoff is claimed.