BS-JD-106 - Brush validation, repair, and diagnostics #15
Closed
opened 2026-06-06 01:46:44 -04:00 by Rbanh
·
6 comments
No Branch/Tag Specified
main
codex/m2-content-workspace
codex/fbx-external-textures
codex/deterministic-asset-fingerprints
codex/guarded-shutdown-savepoints
codex/sample-regression-pack
codex/operator-invariants-completion
codex/renderer-foundation-acceptance
codex/collider-diagnostics
codex/physics-placement
codex/terrain-material-layers
codex/terrain-sculpt-strokes
codex/terrain-foundation
codex/non-blocking-native-dialogs
codex/collaboration-live-acceptance
codex/material-library-targeted-drop
codex/source-control-collaboration-safety
codex/renderer-material-component-foundation
No results found.
Labels
Clear labels
area:animation
area:assets
area:audio
area:brushes
area:build-release
area:extensions
area:governance
area:hierarchy
area:inspector
area:navigation
area:operators
area:physics
area:project-ux
area:quality
area:rendering
area:runtime
area:scene-io
area:terrain
area:viewport
priority:P0
priority:P1
priority:P2
priority:P3
roadmap:jackdaw
roadmap:production
type:architecture
type:docs
type:epic
type:feature
Skeletal animation import, preview, graph/state authoring, and runtime integration.
Asset browser, material browser, thumbnails, import, processing, and asset watcher.
Audio source/listener authoring, buses, spatial preview, and runtime integration.
Brush geometry, CSG, face editing, UVs, and brush diagnostics.
Build profiles, packaging, content validation, release gates, and distribution diagnostics.
Static extension API, extension scaffolds, dylib exploration.
Policy, attribution, planning, and production process.
Outliner hierarchy, parenting, grouping, prefab structure, ordering, and selection workflows.
Inspector, component metadata, component editing UX.
Navigation mesh authoring, baking, diagnostics, and AI path preview.
Editor operator/action framework, undo, commit/cancel semantics.
Physics placement, colliders, rigid bodies, diagnostics, and overlays.
Project launcher, profiles, templates, or first-run project workflow.
Regression packs, tests, performance budgets, profiler, first-hour UX.
Static and skinned renderers, material slots, shaders, ray tracing, and render-path integration.
BRP, remote inspector, PIE, game preview, runtime integration.
Scene document, save/load, schema, migration, or reference repair.
Terrain authoring, terrain sculpting, heightmaps, and terrain materials.
Viewport interaction, selection, shortcuts, camera, overlays, and controls.
Must-have prerequisite or milestone-critical item.
Important production feature after P0 work is stable.
Useful follow-up or polish item.
Exploratory or later spike.
Jackdaw-inspired Blacksite editor roadmap item.
Blacksite production-readiness roadmap item beyond the Jackdaw-inspired foundation.
Architecture, internal framework, or hard-to-reverse technical decision.
Documentation, policy, samples, or issue-board structure.
Tracking epic that groups related milestone work.
User-visible feature or capability.
Milestone
No items
No Milestone
M1 - Brush-based blockout
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Falling-Metal-Interactive/Blacksite#15
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Add robust error handling for degenerate brushes, inverted normals, zero-area faces, and non-manifold results.
Why
Geometry tools fail in messy ways unless validation and repair are built into the workflow.
Implementation notes
Acceptance criteria
Tests/docs
Validation fixtures for each error class. Update troubleshooting docs.
Starting implementation for
BS-JD-106 - Brush validation, repair, and diagnostics.Initial scope:
A dedicated Window > Brush Diagnostics panel and richer repair actions can build on the report type once the shared validation path is stable.
Checkpoint pushed:
4dc22cd Add brush validation diagnostics.Implemented:
validate_brushdiagnostics with warning/error severity.Reset Cube Brushremains the MVP repair action.Verification:
cargo fmt --checkcargo test -p shared brushcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresRemaining follow-up for the full ticket: dedicated multi-brush diagnostics/repair window and richer repair actions beyond reset-to-cube.
Checkpoint pushed:
11b0df2 Block saving invalid brushes.Implemented:
validate_brushforActorKind::Brushactors.InvalidBrushGeometry.Save failed: invalid brush geometry: Face has fewer than three vertices.Verification:
cargo fmt --checkcargo test -p shared brushcargo test -p shared actorcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresRemaining follow-up for the full ticket: richer repair actions and a dedicated multi-brush diagnostics/repair window.
Checkpoint pushed:
09f707b Add brush diagnostics window.Implemented:
Verification:
cargo fmt --checkcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresRemaining follow-up for the full ticket: targeted repair actions beyond reset-to-cube, such as rebuilding face planes or pruning duplicate vertices in place.
Completion checkpoint pushed:
b230593 Expand brush validation coverage.Implemented:
Full #15 coverage now includes:
Verification:
cargo fmt --checkcargo test -p shared brushcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresQA checklist audit completed; no additional local code changes made for this pass.
Evidence reviewed:
validate_brushdetects fatal geometry issues and warnings.InvalidBrushGeometry, blocking unrecoverable invalid scene saves.set_brush_with_history, so the repair is undoable.Verification rerun:
cargo test -p shared brushcargo test -p shared actorcargo check -p editor --all-targetsLeaving #37 checklist unchecked until interactive QA confirms diagnostics window selection/reset and save blocking in the editor.