BS-JD-102 - Quick add and draw-brush tool #11
Closed
opened 2026-06-06 01:46:25 -04:00 by Rbanh
·
9 comments
No Branch/Tag Specified
main
codex/m2-content-workspace
codex/fbx-external-textures
codex/deterministic-asset-fingerprints
codex/guarded-shutdown-savepoints
codex/sample-regression-pack
codex/operator-invariants-completion
codex/renderer-foundation-acceptance
codex/collider-diagnostics
codex/physics-placement
codex/terrain-material-layers
codex/terrain-sculpt-strokes
codex/terrain-foundation
codex/non-blocking-native-dialogs
codex/collaboration-live-acceptance
codex/material-library-targeted-drop
codex/source-control-collaboration-safety
codex/renderer-material-component-foundation
No results found.
Labels
Clear labels
area:animation
area:assets
area:audio
area:brushes
area:build-release
area:extensions
area:governance
area:hierarchy
area:inspector
area:navigation
area:operators
area:physics
area:project-ux
area:quality
area:rendering
area:runtime
area:scene-io
area:terrain
area:viewport
priority:P0
priority:P1
priority:P2
priority:P3
roadmap:jackdaw
roadmap:production
type:architecture
type:docs
type:epic
type:feature
Skeletal animation import, preview, graph/state authoring, and runtime integration.
Asset browser, material browser, thumbnails, import, processing, and asset watcher.
Audio source/listener authoring, buses, spatial preview, and runtime integration.
Brush geometry, CSG, face editing, UVs, and brush diagnostics.
Build profiles, packaging, content validation, release gates, and distribution diagnostics.
Static extension API, extension scaffolds, dylib exploration.
Policy, attribution, planning, and production process.
Outliner hierarchy, parenting, grouping, prefab structure, ordering, and selection workflows.
Inspector, component metadata, component editing UX.
Navigation mesh authoring, baking, diagnostics, and AI path preview.
Editor operator/action framework, undo, commit/cancel semantics.
Physics placement, colliders, rigid bodies, diagnostics, and overlays.
Project launcher, profiles, templates, or first-run project workflow.
Regression packs, tests, performance budgets, profiler, first-hour UX.
Static and skinned renderers, material slots, shaders, ray tracing, and render-path integration.
BRP, remote inspector, PIE, game preview, runtime integration.
Scene document, save/load, schema, migration, or reference repair.
Terrain authoring, terrain sculpting, heightmaps, and terrain materials.
Viewport interaction, selection, shortcuts, camera, overlays, and controls.
Must-have prerequisite or milestone-critical item.
Important production feature after P0 work is stable.
Useful follow-up or polish item.
Exploratory or later spike.
Jackdaw-inspired Blacksite editor roadmap item.
Blacksite production-readiness roadmap item beyond the Jackdaw-inspired foundation.
Architecture, internal framework, or hard-to-reverse technical decision.
Documentation, policy, samples, or issue-board structure.
Tracking epic that groups related milestone work.
User-visible feature or capability.
Milestone
No items
No Milestone
M1 - Brush-based blockout
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Falling-Metal-Interactive/Blacksite#11
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Add brush creation via menu/context actions and a modal draw tool that places vertices on a face or floor, then extrudes to convex brush output.
Why
Brushes need a direct authoring workflow in the viewport, not only data components in the inspector.
Implementation notes
Acceptance criteria
Tests/docs
cargo fmt --checkcargo test -p editor brush_toolcargo test -p shared brush_mathcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresDocs updated in README and docs/editor brush pages.
Committed locally as
48b1448(Improve quick brush creation workflow). Not pushed.Starting implementation for
BS-JD-102 - Quick add and draw-brush tool.Planned scope for this pass:
BrushDescand editor history/operator status.Will keep ticket comments updated as implementation and verification progress.
Completed and committed as
fcd34f9 Add draw brush tool.Implemented:
shared::brush_math.BrushDesc::extruded_prismfor floor-polygon prism brushes.B, toolbar pencil, commandbrush.draw).spawn_with_history, Esc/right-click cancels without scene mutation.Verification:
cargo fmt --checkcargo test -p shared brushcargo test -p editor brush_toolcargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresReopened during M1 QA.
QA finding: Draw Brush creates the actor and Backspace/cancel/commit flow works, but newly-created simple convex brushes are immediately flagged invalid. Inspector diagnostics report
Face plane normal is inverted relative to its verticeson generated faces such asface:+y.Likely root cause: generated prism face winding and stored plane normals disagree after the expanded validator added winding-vs-plane checks. Fixing validator/schema generation before continuing QA.
Local fix is implemented and staged for QA, but not committed or pushed per QA signoff rule.
What changed locally:
BrushDesc::extruded_prismtop/bottom face winding so valid draw-brush prisms no longer fail shared brush validation with inverted face-normal diagnostics.docs/editor/brushes.mdwith the new invalid-outline feedback behavior.Verification passed locally:
cargo fmt --checkcargo test -p editor brush_toolcargo test -p shared brushcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresAwaiting user QA before closing or pushing.
Scope decision from QA discussion:
Local implementation updated for the concave/duplicate draw-brush scope and staged for QA. Not committed or pushed.
What changed locally:
SpawnMany/spawn_many_with_historypath, with all generated parts selected after commit/redo.BrushDesc::extruded_prismnow normalizes floor points before building faces, while preserving convex brush storage/hydration.Verification passed locally:
cargo fmt --checkcargo test -p editor brush_toolcargo test -p shared brushcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresAwaiting user QA before closing, committing, or pushing.
Additional local update staged for QA: Draw Brush now shows viewport key hints while active.
Details:
Additional verification passed locally:
cargo fmt --checkcargo test -p editor brush_toolcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresStill awaiting user QA before closing, committing, or pushing.
Additional local update staged for QA: optimized convex composition generation.
Details:
Additional verification passed locally:
cargo fmt --checkcargo test -p shared brush_mathcargo test -p editor brush_toolcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresStill awaiting user QA before closing, committing, or pushing.
Additional local update staged for QA: two-step height setting for quick brush creation.
Details:
Verification passed locally:
cargo fmt --checkcargo test -p editor brush_toolcargo test -p shared brush_mathcargo check -p editor --all-targetscargo check --workspace --all-targetscargo check --workspace --all-targets --all-featuresStill awaiting user QA before closing, committing, or pushing.